Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove special characters from phone number query #10

Open
coxjonc opened this issue Mar 7, 2017 · 2 comments
Open

Remove special characters from phone number query #10

coxjonc opened this issue Mar 7, 2017 · 2 comments

Comments

@coxjonc
Copy link

coxjonc commented Mar 7, 2017

As a user, I should be allowed to enter a phone number in the entity resolution search as space separated (123 456 789), hyphen separated (123-456-789), or without any delimiter at all (123456789). Currently I can't do that, because the phone numbers are stored in the DB with hyphens as separators.

Instead of strictly enforcing the hyphen format, maybe we should strip out the hyphens from the existing phone numbers in the DB. The app can then strip out any non-numeric characters from the user's query on the backend, and the SQL query will still return matches. This will allow for more robust searching that doesn't break if a user doesn't use the xxx-xxx-xxxx phone number format.

@coxjonc coxjonc changed the title Store phone numbers as numeric digits only, no hyphens or spaces Store phone numbers as numeric digits only, no hyphens Mar 7, 2017
@bmenn
Copy link
Member

bmenn commented Mar 7, 2017

Definitely! I'll queue this up on the board and label everything.

@bmenn
Copy link
Member

bmenn commented Mar 7, 2017

Tasks to do:

  • Strip special characters from phone number query

NOTE: anidata/ht-etl#2 needs to be completed for this to work.

@bmenn bmenn changed the title Store phone numbers as numeric digits only, no hyphens Remove special characters from phone number query Apr 5, 2017
@bmenn bmenn removed the E:easy label Aug 22, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants