Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

DeckPicker should handle menu responsibility instead of StudyOptionsFramgment (Tablet) #17077

Open
SanjaySargam opened this issue Sep 16, 2024 · 0 comments · May be fixed by #17099
Open

DeckPicker should handle menu responsibility instead of StudyOptionsFramgment (Tablet) #17077

SanjaySargam opened this issue Sep 16, 2024 · 0 comments · May be fixed by #17099

Comments

@SanjaySargam
Copy link
Contributor

I think it's unusual that the menus for the fragmented view are the responsibility of the fragment on the right, as it adds complexity to the logic

I would expect the menu to be extracted out of the fragments, and extended to the full width of the activity (with the activity being responsible)

You would then have two menu files for the DeckPicker (fragmented/non), and one for the Options (non-fragmented), and not need to worry about conditionally applying text, or moving some of the processing to the fragment

Originally posted by @david-allison in #16425 (comment)

@SanjaySargam SanjaySargam linked a pull request Sep 21, 2024 that will close this issue
5 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant