Skip to content

Commit b45f8c5

Browse files
committed
fix(modal): fullscreen height calculation error #203
1 parent ca4f1a8 commit b45f8c5

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

src/components/Modal/src/components/ModalWrapper.vue

+6-3
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@
3636
props: {
3737
loading: propTypes.bool,
3838
useWrapper: propTypes.bool.def(true),
39-
modalHeaderHeight: propTypes.number.def(50),
40-
modalFooterHeight: propTypes.number.def(54),
39+
modalHeaderHeight: propTypes.number.def(57),
40+
modalFooterHeight: propTypes.number.def(74),
4141
minHeight: propTypes.number.def(200),
4242
height: propTypes.number,
4343
footerOffset: propTypes.number.def(0),
@@ -137,14 +137,17 @@
137137
138138
if (props.fullScreen) {
139139
realHeightRef.value =
140-
window.innerHeight - props.modalFooterHeight - props.modalHeaderHeight;
140+
window.innerHeight - props.modalFooterHeight - props.modalHeaderHeight - 28;
141141
} else {
142142
realHeightRef.value = props.height
143143
? props.height
144144
: realHeight > maxHeight
145145
? maxHeight
146146
: realHeight;
147147
}
148+
console.log('======================');
149+
console.log(realHeightRef.value, props);
150+
console.log('======================');
148151
emit('height-change', unref(realHeightRef));
149152
} catch (error) {
150153
console.log(error);

0 commit comments

Comments
 (0)