From 1887d390ca61de75bcb520ba920d7676af6d7237 Mon Sep 17 00:00:00 2001 From: Sorin Sbarnea Date: Mon, 10 Oct 2022 19:30:40 +0100 Subject: [PATCH] Avoid warnings with empty role meta files (#2580) Fixes: #2579 --- src/ansiblelint/rules/meta_incorrect.py | 2 +- src/ansiblelint/rules/meta_no_tags.py | 2 +- src/ansiblelint/rules/meta_video_links.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/ansiblelint/rules/meta_incorrect.py b/src/ansiblelint/rules/meta_incorrect.py index 28faa07e99..dfe5f1dfb6 100644 --- a/src/ansiblelint/rules/meta_incorrect.py +++ b/src/ansiblelint/rules/meta_incorrect.py @@ -34,7 +34,7 @@ class MetaChangeFromDefaultRule(AnsibleLintRule): version_added = "v4.0.0" def matchyaml(self, file: Lintable) -> list[MatchError]: - if file.kind != "meta": + if file.kind != "meta" or not file.data: return [] galaxy_info = file.data.get("galaxy_info", None) diff --git a/src/ansiblelint/rules/meta_no_tags.py b/src/ansiblelint/rules/meta_no_tags.py index 5b46734d66..13b8a69188 100644 --- a/src/ansiblelint/rules/meta_no_tags.py +++ b/src/ansiblelint/rules/meta_no_tags.py @@ -33,7 +33,7 @@ class MetaTagValidRule(AnsibleLintRule): def matchyaml(self, file: Lintable) -> list[MatchError]: """Find violations inside meta files.""" - if file.kind != "meta": + if file.kind != "meta" or not file.data: return [] galaxy_info = file.data.get("galaxy_info", None) diff --git a/src/ansiblelint/rules/meta_video_links.py b/src/ansiblelint/rules/meta_video_links.py index 1f3a40036c..402844a472 100644 --- a/src/ansiblelint/rules/meta_video_links.py +++ b/src/ansiblelint/rules/meta_video_links.py @@ -33,7 +33,7 @@ class MetaVideoLinksRule(AnsibleLintRule): } def matchyaml(self, file: Lintable) -> list[MatchError]: - if file.kind != "meta": + if file.kind != "meta" or not file.data: return [] galaxy_info = file.data.get("galaxy_info", None)