Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

improve abi generation #226

Merged
merged 2 commits into from
Sep 22, 2023
Merged

improve abi generation #226

merged 2 commits into from
Sep 22, 2023

Conversation

dimas1185
Copy link
Contributor

@dimas1185 dimas1185 commented Sep 19, 2023

fixes #225

after #201 we introduced a new logic where structure defined out of contract doesn't go to ABI.
There is an exception to that that is actively used by system contract. A lot of structures are defined out of contract but those have [[eosio::contract("name")]] tag. That case was added to exceptions and also search of contract class was improved as in some cases in reference-contracts it was not found the old way. Also a fix added where structure that was defined out of contract was not properly defined in structures. That is reflected in singleton_contract.abi and corresponding test.

Change Description

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@heifner
Copy link
Member

heifner commented Sep 19, 2023

Please add a better PR description.

@greg7mdp
Copy link

@dimas1185 I'm sorry I don't know enough to review this.

@dimas1185 dimas1185 merged commit bf7fe2e into main Sep 22, 2023
@dimas1185 dimas1185 deleted the fix-ref-contracts branch September 22, 2023 16:03
@dimas1185 dimas1185 mentioned this pull request Sep 22, 2023
2 tasks
@ericpassmore ericpassmore added this to the CDT 4.1.0-rc1 milestone Dec 21, 2023
@ericpassmore
Copy link
Contributor

Note:start
group: STABILITY
category: BUG
summary: Backward compatible for ABI generation in older system contracts by including structures defined in an extended context.
Note:end

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix reference-contracts abi
5 participants