Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Feat: Change cheat-code types from ethers types to alloy types #606

Closed
0xJepsen opened this issue Oct 12, 2023 · 0 comments · Fixed by #725
Closed

Feat: Change cheat-code types from ethers types to alloy types #606

0xJepsen opened this issue Oct 12, 2023 · 0 comments · Fixed by #725
Labels
✨ enhancement new feature, upgrade, or change in modularity 🌱 good first issue small task good for getting started

Comments

@0xJepsen
Copy link
Collaborator

Idea

Currently in some of our cheatcodes for example in Deal we have the types specified as ethers types. It would be nice if we only exposed the end user to alloy types.
@0xJepsen 0xJepsen added ✨ enhancement new feature, upgrade, or change in modularity 🌱 good first issue small task good for getting started labels Oct 12, 2023
@quidproquoo quidproquoo mentioned this issue Nov 27, 2023
Merged
@0xJepsen 0xJepsen linked a pull request Nov 29, 2023 that will close this issue
feat: Change types from ethers types to alloy types in cheatcodes #725
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
✨ enhancement new feature, upgrade, or change in modularity 🌱 good first issue small task good for getting started
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Change types from ethers types to alloy types in cheatcodes quidproquoo/arbiter
1 participant
@0xJepsen