Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

K test fails #4

Closed
davidanthoff opened this issue Mar 7, 2018 · 4 comments
Closed

K test fails #4

davidanthoff opened this issue Mar 7, 2018 · 4 comments
Assignees
@corakingdon
Labels
bug Something isn't working

Comments

@davidanthoff
Copy link
Member

As we already discussed, I think you can just relax the tolerance there.
@davidanthoff davidanthoff added the bug Something isn't working label Mar 7, 2018
@corakingdon
Copy link
Collaborator

@davidanthoff should I relax it for just this variable's test, or for everything?

@davidanthoff
Copy link
Member Author

I'd just relax it for this variable.

@corakingdon
Copy link
Collaborator

PR #6

@davidanthoff
Copy link
Member Author

Excellent. One small trick: if you write something like Fixes #4 in the comment section of the PR that fixes an issue, it will automatically link to the issue, and then close it when the PR is merged :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@corakingdon corakingdon

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davidanthoff @corakingdon