Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

async_write may overflow #10

Closed
dgrr opened this issue Feb 16, 2021 · 1 comment
Closed

async_write may overflow #10

dgrr opened this issue Feb 16, 2021 · 1 comment
Assignees
@antlad

Comments

@dgrr
Copy link

dgrr commented Feb 16, 2021

Hello,

Why is the code adding +4 here instead of +2?
Since the calculation is header_size + body_size + \r\n, why are you adding +4?

Thanks beforehand.
@antlad
Copy link
Owner

antlad commented Mar 13, 2021 •
edited
Loading

Looks like typo, thank you

@antlad antlad self-assigned this Mar 13, 2021
@antlad antlad closed this as completed in 51708f9 Mar 16, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@antlad antlad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@antlad @dgrr