From 7fdec95d15a1ca44928a8f146fc7c49ed51bf527 Mon Sep 17 00:00:00 2001 From: ralf Date: Thu, 29 Nov 2018 10:44:47 +0100 Subject: [PATCH 1/2] added virtual dtor to polymorphic class template ParseTreeProperty --- runtime/Cpp/runtime/src/tree/ParseTreeProperty.h | 1 + 1 file changed, 1 insertion(+) diff --git a/runtime/Cpp/runtime/src/tree/ParseTreeProperty.h b/runtime/Cpp/runtime/src/tree/ParseTreeProperty.h index d3eb83554d..8669a1046e 100755 --- a/runtime/Cpp/runtime/src/tree/ParseTreeProperty.h +++ b/runtime/Cpp/runtime/src/tree/ParseTreeProperty.h @@ -29,6 +29,7 @@ namespace tree { template class ANTLR4CPP_PUBLIC ParseTreeProperty { public: + virtual ~ParseTreeProperty() {} virtual V get(ParseTree *node) { return _annotations[node]; } From 80230131ac2784e90554f80510ef5d4df1a0174f Mon Sep 17 00:00:00 2001 From: ralf Date: Thu, 29 Nov 2018 11:03:49 +0100 Subject: [PATCH 2/2] added virtual dtor to polymorphic class template ParseTreeProperty and added myself as contributor --- contributors.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/contributors.txt b/contributors.txt index 441f9675de..ebfee23654 100644 --- a/contributors.txt +++ b/contributors.txt @@ -208,3 +208,4 @@ YYYY/MM/DD, github id, Full name, email 2018/11/12, vinoski, Steve Vinoski, vinoski@ieee.org 2018/11/14, nxtstep, Adriaan (Arjan) Duz, codewithadriaan[et]gmail[dot]com 2018/11/15, amykyta3, Alex Mykyta, amykyta3@users.noreply.github.com +2018/11/29, hannemann-tamas, Ralf Hannemann-Tamas, ralf.ht@gmail.com