Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Connections using proxy protocol on v1.1.6 are broken #188

Closed
antoniomika opened this issue Aug 5, 2021 · 0 comments · Fixed by #191
Closed

Connections using proxy protocol on v1.1.6 are broken #188

antoniomika opened this issue Aug 5, 2021 · 0 comments · Fixed by #191
Assignees
@antoniomika
Labels
bug Something isn't working

Comments

@antoniomika
Copy link
Owner

As a result of pires/go-proxyproto#74 and switching back to upstream, using proxy protocol prevents users from connecting to sish if a low proxy-protocol-timeout is used (which is the default).

I'm opening this issue to track the progress in pires/go-proxyproto#76, so that I can apply a fix. If we don't get a response there by tomorrow, I'll likely revert the change back to upstream until that patch is available.
@antoniomika antoniomika added the bug Something isn't working label Aug 5, 2021
@antoniomika antoniomika self-assigned this Aug 5, 2021
@antoniomika antoniomika mentioned this issue Sep 9, 2021
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@antoniomika antoniomika

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated dependencies to solve proxy proto issues antoniomika/sish
1 participant
@antoniomika