Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

onEdgeLabelRendered 类型错误 #4577

Open
wsi18n opened this issue Feb 14, 2025 · 2 comments
Open

onEdgeLabelRendered 类型错误 #4577

wsi18n opened this issue Feb 14, 2025 · 2 comments

Comments

@wsi18n
Copy link

wsi18n commented Feb 14, 2025

Describe the bug

Image

should change to

onEdgeLabelRendered?: ((args: OnEdgeLabelRenderedArgs) => undefined | void);

onEdgeLabelRendered?: (args: OnEdgeLabelRenderedArgs) => undefined | ((args: OnEdgeLabelRenderedArgs) => void);

means

onEdgeLabelRendered?: (args: OnEdgeLabelRenderedArgs) => (undefined | ((args: OnEdgeLabelRenderedArgs) => void));

and

 onEdgeLabelRendered: (args) => (args2) => console.log(args);

not work

Your Example Website or App

any

Steps to Reproduce the Bug or Issue

none

Expected behavior

onEdgeLabelRendered?: (args: OnEdgeLabelRenderedArgs) => undefined | ((args: OnEdgeLabelRenderedArgs) => void);

=>

onEdgeLabelRendered?: ((args: OnEdgeLabelRenderedArgs) => undefined |  void);

Screenshots or Videos

No response

Platform

any

Additional context

No response

@x6-bot
Copy link
Contributor

x6-bot bot commented Feb 14, 2025

👋 @wsi18n

Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it.
To help make it easier for us to investigate your issue, please follow the contributing guidelines.
We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

@louhaojie99
Copy link

Describe the bug

Image

should change to

onEdgeLabelRendered?: ((args: OnEdgeLabelRenderedArgs) => undefined | void);
onEdgeLabelRendered?: (args: OnEdgeLabelRenderedArgs) => undefined | ((args: OnEdgeLabelRenderedArgs) => void);

means

onEdgeLabelRendered?: (args: OnEdgeLabelRenderedArgs) => (undefined | ((args: OnEdgeLabelRenderedArgs) => void));

and

 onEdgeLabelRendered: (args) => (args2) => console.log(args);

not work

Your Example Website or App

any

Steps to Reproduce the Bug or Issue

none

Expected behavior

onEdgeLabelRendered?: (args: OnEdgeLabelRenderedArgs) => undefined | ((args: OnEdgeLabelRenderedArgs) => void);

=>

onEdgeLabelRendered?: ((args: OnEdgeLabelRenderedArgs) => undefined |  void);

Screenshots or Videos

No response

Platform

any

Additional context

No response

他这个函数错误地将返回值类型定义为 undefined。对不需要返回值的函数,应使用 void,我建议修改为:

onEdgeLabelRendered?: (args: OnEdgeLabelRenderedArgs) => void;

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants