Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: area chart support smooth shape #1275

Merged
merged 4 commits into from
Nov 18, 2021
Merged

feat: area chart support smooth shape #1275

merged 4 commits into from
Nov 18, 2021

Conversation

El-Chiang
Copy link
Contributor

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change

@El-Chiang El-Chiang changed the title feat: area chart support smooth shape feat: area chart supports smooth shape Nov 16, 2021
@El-Chiang El-Chiang changed the title feat: area chart supports smooth shape feat: area chart support smooth shape Nov 16, 2021
...shape,
}}
createPath={(context) => {
const constaint = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感觉这段逻辑应该放到 polygon 里,让 polygon 也支持 smooth 属性会比较好

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改 graphic 吗

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

那先这样吧,后面再看吧

@zengyue zengyue merged commit 593b323 into v4.0.x Nov 18, 2021
@zengyue zengyue deleted the feat/smooth-area branch November 18, 2021 08:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants