Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

HashRouting: load_from_cache not working, when changing templates. #367

Closed
augustasvol opened this issue Aug 3, 2022 · 5 comments · Fixed by #368
Closed

HashRouting: load_from_cache not working, when changing templates. #367

augustasvol opened this issue Aug 3, 2022 · 5 comments · Fixed by #368

Comments

@augustasvol
Copy link

augustasvol commented Aug 3, 2022

Describe the bug

  • In HashRouting module.
  • Using the function set_url_hash with load_from_cache=False.
  • Does not work if the route is changing templates.
  • Loads the page from cache.
@s-cork
Copy link
Collaborator

s-cork commented Aug 3, 2022

@augustasvol - Could you provide a clone and reproduction steps

@augustasvol
Copy link
Author

@augustasvol - Could you provide a clone and reproduction steps

Sure, I'll do it in a few minutes.

@augustasvol
Copy link
Author

augustasvol commented Aug 3, 2022

Here is an Anvil clone link that reproduces the problem.

https://anvil.works/build#clone:WMTZNWRATRLLE2LO=CKZVU3TXKRRLJKVT2FRQYKNZ|C6ZZPAPN4YYF5NVJ=

Link to check how it behaves:
https://elastic-downright-bilby.anvil.app/

  • When navigating, to page with a different template.
  • When navigating to the same URL (using set_url_hash("/some", load_from_cache=False)
  • Pages load from cache.

This does not happen when navigating to a page with the same template.

@s-cork
Copy link
Collaborator

s-cork commented Aug 3, 2022

yeah - that make sense based on the implementation, I'll have to have a think about this one

@s-cork s-cork mentioned this issue Aug 3, 2022
@augustasvol
Copy link
Author

@s-cork thank you for fixing this.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants