GO-4727 local counters for chat #2039
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
requilence
force-pushed
the
go-4727-local-counters-for-chat
branch
from
283d66c to
a1c97db
Compare
deff7
reviewed
Feb 4, 2025
| oldestOrderId = doc.Value().GetObject(orderKey).Get("id").GetString() | ||
| } | ||
|
|
||
| count, err := unreadQuery.Count(ctx) |
There was a problem hiding this comment.
Seems like count is 0 or 1 because of limit=1
mcrakhman
reviewed
Feb 5, 2025
| } | ||
|
|
||
| // mark the whole tree as seen from the current message | ||
| s.storeSource.MarkSeenHeads([]string{msg.Id}) |
There was a problem hiding this comment.
As discussed there should be many messages, not one marked as head, because otherwise we will miss some read messages. Pls change it
| // for testing purposes | ||
| lastAddedMessageTimestamp = math.MaxInt64 | ||
| } | ||
| iter, err := coll.Find( |
There was a problem hiding this comment.
Should we also add filter for unread messages?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: