-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
GO-4844: API Analytics from MW #2095
base: main
Are you sure you want to change the base?
Conversation
Coverage provided by https://github.com/seriousben/go-patch-cover-action |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
core/api/server/server.go:34
- [nitpick] The comment for the KeyToToken mapping still refers to a token, but the map now holds ApiSessionEntry objects. Consider updating the comment to accurately reflect the stored type.
KeyToToken map[string]ApiSessionEntry // appKey -> token
"encoding/json" | ||
"log" | ||
|
||
"golang.org/x/net/context" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with other parts of the codebase that use the standard library context, consider replacing 'golang.org/x/net/context' with 'context'.
"golang.org/x/net/context" | |
"context" |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
analyticsEvent
to client for all actions taken through API.ensureAnalyticsEvent(code, eventService)
sends an event with thecode
specified inrouter.go
for the corresponding route.apiAppName
param, which is derived from app name tied to api token (app key) used for current request.