-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Colors codes being stripped out #62
Comments
I have a pull request with a proposed fix. |
Couldn't we add a regexp so the word is skipped ? or the thing is that is not being taken into account by the regepx before being split into # and fff ? |
The only line that is changed is the RegExp that handles removing characters before the text is evaluated... The only difference is that it now extracts only those hash symbols that do not precede a color code pattern. I think the change accomplishes the task. |
Any chance you could review and approve this change? It has been almost three months since the PR was submitted and we are still encountering this issue. |
Does not appear this plugin is being maintained. Closing |
Hi @smallstepstoday this plugin is being maintained, but in my spare time looks like i didnt check your pr on time, sorry. |
Let me check if my proposed solution is ok. |
This line is stripping out the pound sign (#) before color codes in tagged template literals, like those for
styled-components
. For example,turns
#fff
intofff
, making it impossible to determine if this is a color code.The text was updated successfully, but these errors were encountered: