From d3df0abd68cb03c4e75854831596d52f46986b8c Mon Sep 17 00:00:00 2001 From: Rok Mihevc Date: Sun, 16 Feb 2025 15:02:36 +0100 Subject: [PATCH] Review feedback --- parquet/src/arrow/async_reader/metadata.rs | 4 ++-- parquet/src/arrow/async_reader/mod.rs | 2 +- parquet/src/file/metadata/reader.rs | 8 ++++---- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/parquet/src/arrow/async_reader/metadata.rs b/parquet/src/arrow/async_reader/metadata.rs index 53f992e424c7..4f41cd6ceebd 100644 --- a/parquet/src/arrow/async_reader/metadata.rs +++ b/parquet/src/arrow/async_reader/metadata.rs @@ -131,7 +131,7 @@ impl MetadataLoader { ( ParquetMetaDataReader::decode_metadata( &meta, - footer.encrypted_footer(), + footer.is_encrypted_footer(), #[cfg(feature = "encryption")] None, )?, @@ -144,7 +144,7 @@ impl MetadataLoader { ( ParquetMetaDataReader::decode_metadata( slice, - footer.encrypted_footer(), + footer.is_encrypted_footer(), #[cfg(feature = "encryption")] None, )?, diff --git a/parquet/src/arrow/async_reader/mod.rs b/parquet/src/arrow/async_reader/mod.rs index 321ca5f52a5e..be41065f71f7 100644 --- a/parquet/src/arrow/async_reader/mod.rs +++ b/parquet/src/arrow/async_reader/mod.rs @@ -179,7 +179,7 @@ impl AsyncFileReader for T { Ok(Arc::new(ParquetMetaDataReader::decode_metadata( &buf, - footer.encrypted_footer(), + footer.is_encrypted_footer(), #[cfg(feature = "encryption")] file_decryption_properties, )?)) diff --git a/parquet/src/file/metadata/reader.rs b/parquet/src/file/metadata/reader.rs index 87a964b89d30..62e0b61bec4c 100644 --- a/parquet/src/file/metadata/reader.rs +++ b/parquet/src/file/metadata/reader.rs @@ -95,7 +95,7 @@ impl FooterTail { } /// Whether the footer metadata is encrypted - pub fn encrypted_footer(&self) -> bool { + pub fn is_encrypted_footer(&self) -> bool { self.encrypted_footer } } @@ -570,7 +570,7 @@ impl ParquetMetaDataReader { let start = file_size - footer_metadata_len as u64; Self::decode_metadata( chunk_reader.get_bytes(start, metadata_len)?.as_ref(), - footer.encrypted_footer(), + footer.is_encrypted_footer(), #[cfg(feature = "encryption")] self.file_decryption_properties.as_ref(), ) @@ -639,7 +639,7 @@ impl ParquetMetaDataReader { Ok(( Self::decode_metadata( &meta, - footer.encrypted_footer(), + footer.is_encrypted_footer(), #[cfg(feature = "encryption")] file_decryption_properties, )?, @@ -651,7 +651,7 @@ impl ParquetMetaDataReader { Ok(( Self::decode_metadata( slice, - footer.encrypted_footer(), + footer.is_encrypted_footer(), #[cfg(feature = "encryption")] file_decryption_properties, )?,