Skip to content

ListBuilder Specify Field #1649

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
tustvold opened this issue May 5, 2022 · 1 comment
Closed

ListBuilder Specify Field #1649

tustvold opened this issue May 5, 2022 · 1 comment
Labels
enhancement Any new improvement worthy of a entry in the changelog

Comments

@tustvold
Copy link
Contributor

tustvold commented May 5, 2022 •
edited
Loading

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

The various ListBuilder's do not support providing the full Field of the nested type, this prevents round-tripping nullability, field names, etc...

Describe the solution you'd like

The ListBuilders should have a new public constructor

pub fn new_with_child(values_builder: T, child: Field) -> Self

This should panic in finish if the field has an incompatible data_type

Describe alternatives you've considered

We could not do this

Additional context

I ran into this whilst working on apache/datafusion#2450
@tustvold tustvold added the enhancement Any new improvement worthy of a entry in the changelog label May 5, 2022
@tustvold tustvold mentioned this issue May 5, 2022
Open
@tustvold tustvold mentioned this issue May 18, 2022
Closed
@tustvold
Copy link
Contributor Author

Closed by #5331

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tustvold