Skip to content

Some unsafe code in arrow is seemingly unsound or not very well documented. #6020

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
veluca93 opened this issue Jul 8, 2024 · 2 comments
Labels
enhancement Any new improvement worthy of a entry in the changelog help wanted

Comments

@veluca93
Copy link
Contributor

veluca93 commented Jul 8, 2024

Hi all,
while going through the code in arrow, I spotted a few places in which the usage of unsafe code is unsound, and a few in which I could not determine whether it was or not.

I do not believe that the issues I found could cause problems today, but I prepared a PR nonetheless that fixes the unsound cases I could find, improves documentation in the cases in which I could figure out why the code is indeed sound, and leaves a FIXME comment for the remaining cases that were beyond my ability to figure out :-)

I hope this helps!

@alamb
Copy link
Contributor

alamb commented Jul 8, 2024

Thank you @veluca93

@tustvold tustvold added enhancement Any new improvement worthy of a entry in the changelog help wanted and removed bug labels Jul 9, 2024
@tustvold
Copy link
Contributor

tustvold commented Jul 9, 2024

Thank you for this, I've changed this to be labeled as an enhancement as I don't believe there is unsoundness in user-facing APIs and I'd like to avoid causing undue wailing and gnashing of teeth. Please do correct me if I have misunderstood

As an aside thank you for adopting a constructive tone, its unfortunately not a given when it comes to areas such as this

@alamb alamb changed the title Some unsafe code in arrow is unsound or not very well documented. Some seemingly unsafe code in arrow is unsound or not very well documented. Jul 9, 2024
@alamb alamb changed the title Some seemingly unsafe code in arrow is unsound or not very well documented. Some unsafe code in arrow is seemingly unsound or not very well documented. Jul 9, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog help wanted
Projects
None yet
Development

No branches or pull requests

3 participants