Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Should cordova plugin save be removed/updated? #558

Closed
matt-auckland opened this issue May 17, 2021 · 2 comments · Fixed by #559
Closed

Should cordova plugin save be removed/updated? #558

matt-auckland opened this issue May 17, 2021 · 2 comments · Fixed by #559

Comments

@matt-auckland
Copy link
Contributor

matt-auckland commented May 17, 2021

Feature Request

Note: I'm happy to help implement this feature myself if it's deemed worthy of implementation

Either remove the feature straight up, or perhaps running it could update the package.json instead of the config.xml?

We could start by deprecating if removal is the option of choice.

Motivation Behind Feature

cordova plugin save add the currently installed plugins into the config.xml as <plugin> elements.

Since the cordova CLI no longer looks to the config.xml for plugin information, perhaps it's time for this command to be repurposed or removed altogether?

@raphinesse
Copy link
Contributor

Thanks for bringing this to our attention. Since we save the list of installed plugins to configuration files by default for quite some time now, I would argue we should remove that command altogether.

@matt-auckland
Copy link
Contributor Author

Looks like it's already been removed from cordova-lib here: apache/cordova-lib#781 .
It's also been removed from the cli here as well: #486

All that remains is that it appears when you run cordova plugin --help, so removing that here: #559

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants