CB-14181: (android) Fix bug - Cannot read property 'filesystemName' of null (#235)

jony89 · jcesarmobile · commit cc3aedb0abb2 · 2018-06-30T20:49:04.000+02:00
CB-14181: (android)  fix: Cannot read property 'filesystemName' of null

fix error :

Error in Success callbackId: File1539060614 : TypeError: Cannot read property 'filesystemName' of null
cordova.js:314 Uncaught TypeError: Cannot read property 'filesystemName' of null

The `fsRoot` might be null. reproduced with latest cordova on android emulator.

* fix: eslint
diff --git a/www/fileSystems-roots.js b/www/fileSystems-roots.js
@@ -30,8 +30,10 @@ require('./fileSystems').getFs = function (name, callback) {
         fsMap = {};
         for (var i = 0; i < response.length; ++i) {
             var fsRoot = response[i];
-            var fs = new FileSystem(fsRoot.filesystemName, fsRoot);
-            fsMap[fs.name] = fs;
+            if (fsRoot) {
+                var fs = new FileSystem(fsRoot.filesystemName, fsRoot);
+                fsMap[fs.name] = fs;
+            }
         }
         callback(fsMap[name]);
     }

Original file line number	Diff line number	Diff line change
`@@ -30,8 +30,10 @@ require('./fileSystems').getFs = function (name, callback) {`
`30`	`30`	`fsMap = {};`
`31`	`31`	`for (var i = 0; i < response.length; ++i) {`
`32`	`32`	`var fsRoot = response[i];`
`33`		`- var fs = new FileSystem(fsRoot.filesystemName, fsRoot);`
`34`		`- fsMap[fs.name] = fs;`
	`33`	`+ if (fsRoot) {`
	`34`	`+ var fs = new FileSystem(fsRoot.filesystemName, fsRoot);`
	`35`	`+ fsMap[fs.name] = fs;`
	`36`	`+ }`
`35`	`37`	`}`
`36`	`38`	`callback(fsMap[name]);`
`37`	`39`	`}`