Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Consolidate tests for unparser / plan to sql to make them easier to find #10635

Closed
alamb opened this issue May 23, 2024 · 0 comments · Fixed by #10736
Closed

Consolidate tests for unparser / plan to sql to make them easier to find #10635

alamb opened this issue May 23, 2024 · 0 comments · Fixed by #10736
Labels
development-process Related to development process of DataFusion

Comments

@alamb
Copy link
Contributor

alamb commented May 23, 2024

          Since this is testing `plan_to_sql` it might make more sense to put it with the rest of the tests for plan_to_sql:  https://github.com/apache/datafusion/blob/main/datafusion/sql/tests/sql_integration.rs#L4669

However, the fact that those tests don't have "plan_to_sql" in their name is confusing too.

Maybe we could consolidate the tests into something like datafusion/sql/tests/sql_integration/plan_to_sql.rs 🤔 (as a follow on PR)

Originally posted by @alamb in #10612 (comment)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
development-process Related to development process of DataFusion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant