Skip to content

Converge StructFunc and NamedStructFunc to one func #11204

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
jayzhan211 opened this issue Jul 2, 2024 · 1 comment
Closed

Converge StructFunc and NamedStructFunc to one func #11204

jayzhan211 opened this issue Jul 2, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@jayzhan211
Copy link
Contributor

jayzhan211 commented Jul 2, 2024

Is your feature request related to a problem or challenge?

We currently have two func StructFunc and NamedStructFunc, where StructFunc is actually NamedStructFunc with default naming c1, c2... cn

I think it is easier to maintain the code if we have only one single struct function. If the name of field is not given, we fallback to default name "c{index}"

Describe the solution you'd like

Simplify the divergence of these two functions with minimum breaking change.

Also, converge create_named_struct and create_struct to one in sqltorel

Describe alternatives you've considered

Keep as it is

Additional context

No response
This also help #9820 easier to implement

@jayzhan211
Copy link
Contributor Author

jayzhan211 commented Jul 2, 2024

Close, it does not seem possible to differentiate two with the same name and the same arguments args: Vec<Expr>

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant