We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Recently merged PR "Improve push down filter of join #13184" introduces correctness issues.
I did not look closely at the code, but the example in the PR description seems incorrect. See reproducer for why.
> CREATE TABLE t1 (c0 CHAR, c1 INT) AS VALUES ('a', 1); CREATE TABLE t2 (c0 CHAR, c1 INT); SELECT * FROM t1 LEFT JOIN t2 ON t1.c0 = t2.c0 WHERE abs(t2.c1) > 5; 0 row(s) fetched. Elapsed 0.011 seconds. 0 row(s) fetched. Elapsed 0.006 seconds. +----+----+----+----+ | c0 | c1 | c0 | c1 | +----+----+----+----+ | a | 1 | | | +----+----+----+----+
Before that commit Datafusion correct produced empty output
DataFusion CLI v42.2.0 > CREATE TABLE t1 (c0 CHAR, c1 INT) AS VALUES ('a', 1); CREATE TABLE t2 (c0 CHAR, c1 INT); SELECT * FROM t1 LEFT JOIN t2 ON t1.c0 = t2.c0 WHERE abs(t2.c1) > 5; 0 row(s) fetched. Elapsed 0.015 seconds. 0 row(s) fetched. Elapsed 0.008 seconds. +----+----+----+----+ | c0 | c1 | c0 | c1 | +----+----+----+----+ +----+----+----+----+ 0 row(s) fetched. Elapsed 0.019 seconds.
No response
The text was updated successfully, but these errors were encountered:
FYI @JasonLi-cn and @Dandandan
Sorry, something went wrong.
Oops... we need to revert it, will probably do so the weekend if noone else does it.
Created #13229 for reverting
Successfully merging a pull request may close this issue.
Uh oh!
There was an error while loading. Please reload this page.
Describe the bug
Recently merged PR "Improve push down filter of join #13184" introduces correctness issues.
I did not look closely at the code, but the example in the PR description seems incorrect. See reproducer for why.
To Reproduce
Expected behavior
Before that commit Datafusion correct produced empty output
Additional context
No response
The text was updated successfully, but these errors were encountered: