Skip to content

Type coercion for binary operators forces UTF8View to Utf8 #13348

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
Omega359 opened this issue Nov 11, 2024 · 3 comments
Closed

Type coercion for binary operators forces UTF8View to Utf8 #13348

Omega359 opened this issue Nov 11, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@Omega359
Copy link
Contributor

Describe the bug

This is a cleanup ticket for #12212 which had introduced logic for regexp forcing coercion to Utf8 if any side had utf8View. This looks to have been done before #12180 landed which to my understanding should negate the need for this.

However, I think fixing regexp_match to support utf8View should likely land before the special handling code and tests introduced in #12212 is removed.

To Reproduce

See

Expected behavior

Utf8View is supported and not coerced to Utf8 for all regexp functions including via binary operators.

Additional context

No response

@Omega359 Omega359 added the bug Something isn't working label Nov 11, 2024
@jayzhan211
Copy link
Contributor

I think change the signature to TypeSignature::String can solve this issue. See #13301

@jayzhan211
Copy link
Contributor

jayzhan211 commented Nov 11, 2024

regex_comparison_string_coercion is the same as string_coercion, can we remove it and use string_coercion instead?

I saw the comment 👍

@alamb
Copy link
Contributor

alamb commented Mar 8, 2025

I think we have completed this issue now -- let's close it (and if it is not closed, perhaps we can file a ticket that explains the end user effect / reproducer so we can get it fixed)

@alamb alamb closed this as completed Mar 8, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants