Skip to content

Update ClickBench benchmarks with DataFusion 45.0.0 (When Published) #14246

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
alamb opened this issue Jan 23, 2025 · 13 comments
Closed

Update ClickBench benchmarks with DataFusion 45.0.0 (When Published) #14246

alamb opened this issue Jan 23, 2025 · 13 comments
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Jan 23, 2025

Is your feature request related to a problem or challenge?

Describe the solution you'd like

Once DataFusion 45.0.0 is released, It would be great to update ClickBench https://benchmark.clickhouse.com/ with the newest version

ClickBench is a benchmark heavy on filtering and aggregation that we have used as an optimization target for the last several releases.

Describe alternatives you've considered

Additional context

Improvements I know of:

@Dandandan
Copy link
Contributor

Would be nice to get this in as well #13681

@Rachelint
Copy link
Contributor

Rachelint commented Jan 23, 2025

Would be nice to get this in as well #13681

I added fuzzy tests for it in my local, and found some failed cases for Decimal today ...
I am fixing it, and working for benchmark, I think it can be finished today or tomorrow.

@Dandandan
Copy link
Contributor

Thank you very much @Rachelint

@alamb
Copy link
Contributor Author

alamb commented Jan 23, 2025

Would be nice to get this in as well #13681

I agree (though I don't think it will help ClickBench as clickbench doesn't have a median aggregate)

Added to release checklist on

@Rachelint
Copy link
Contributor

#13681 is ready for review

@pmcgleenon
Copy link
Contributor

Here are the initial ClickBench results for datafusion 45.0.0

clickbench-latest 3.html.zip

Image Image

If it looks reasonable, I can create a ClickBench PR to update the results

@alamb
Copy link
Contributor Author

alamb commented Feb 8, 2025

If it looks reasonable, I can create a ClickBench PR to update the results

It does look reasonable to me. Thank you @pmcgleenon 🙏

@pmcgleenon
Copy link
Contributor

Makes sense 👍

I've created a PR ClickHouse/ClickBench#304

@pmcgleenon
Copy link
Contributor

FYI the Clickbench PR has been merged and the latest Datafusion 45.0.0 results have been published on the site https://benchmark.clickhouse.com/

@alamb
Copy link
Contributor Author

alamb commented Feb 10, 2025

FYI the Clickbench PR has been merged and the latest Datafusion 45.0.0 results have been published on the site https://benchmark.clickhouse.com/

Thank you so much @pmcgleenon

@alamb alamb closed this as completed Feb 10, 2025
@Dandandan
Copy link
Contributor

Nice! Looks we have some more competition now from DuckDB: results

Image

@alamb
Copy link
Contributor Author

alamb commented Feb 10, 2025

Nice! Looks we have some more competition now from DuckDB:...

@alamb
Copy link
Contributor Author

alamb commented Feb 10, 2025

Filed a ticket for running this on 46

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants