Skip to content

Set default value of parse_float_as_decimal to true #14612

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
andygrove opened this issue Feb 11, 2025 · 1 comment · May be fixed by #14752
Open

Set default value of parse_float_as_decimal to true #14612

andygrove opened this issue Feb 11, 2025 · 1 comment · May be fixed by #14752
Assignees
Labels
enhancement New feature or request

Comments

@andygrove
Copy link
Member

Is your feature request related to a problem or challenge?

According to the ANSI SQL specification, floating point numbers in SQL should be interpreted as decimals. We currently interpret them as floats:

    pub struct SqlParserOptions {
        /// When set to true, SQL parser will parse float as decimal type
        pub parse_float_as_decimal: bool, default = false

Describe the solution you'd like

Set default to true and fix regressions in test suite. This will likely involve fixing some bugs in type coercion such as #14272

Describe alternatives you've considered

No response

Additional context

No response

@andygrove andygrove added the enhancement New feature or request label Feb 11, 2025
@jatin510
Copy link
Contributor

take

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants