Skip to content

Migrate Datetime functions to invoke_with_args #14705

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
goldmedal opened this issue Feb 17, 2025 · 6 comments · Fixed by #14876
Closed

Migrate Datetime functions to invoke_with_args #14705

goldmedal opened this issue Feb 17, 2025 · 6 comments · Fixed by #14876
Assignees
@haydenwoodhead @onlyjackfrost @aviral-bhardwaj @varun-bhardwaj-sde
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@goldmedal
Copy link
Contributor

Is your feature request related to a problem or challenge?

As #14652, invoke_batch is deprecated. We should migrate all the UDFs to invoke_with_args. This issue would focus on the function in the datafusion/functions/src/datetime.

Describe the solution you'd like

  • Remove invoke_batch for the function implementation and use implement invoke_with_args instead.

Describe alternatives you've considered

No response

Additional context

No response
@goldmedal goldmedal added enhancement New feature or request good first issue Good for newcomers labels Feb 17, 2025
@haydenwoodhead
Copy link

I'd be keen to give this a go.

@goldmedal
Copy link
Contributor Author

I'd be keen to give this a go.

Thanks @haydenwoodhead. Feel free to use take keyword to assign yourself.

@haydenwoodhead
Copy link

take

@niebayes niebayes mentioned this issue Feb 17, 2025
Closed
@aviral-bhardwaj
Copy link

take

@varun-bhardwaj-sde varun-bhardwaj-sde mentioned this issue Feb 20, 2025
Closed
@varun-bhardwaj-sde
Copy link

take

@varun-bhardwaj-sde varun-bhardwaj-sde mentioned this issue Feb 25, 2025
Closed
@onlyjackfrost
Copy link
Contributor

take

@onlyjackfrost onlyjackfrost mentioned this issue Feb 25, 2025
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@haydenwoodhead haydenwoodhead

@onlyjackfrost onlyjackfrost

@aviral-bhardwaj aviral-bhardwaj

@varun-bhardwaj-sde varun-bhardwaj-sde

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
5 participants
@goldmedal @haydenwoodhead @onlyjackfrost @aviral-bhardwaj @varun-bhardwaj-sde