-
Notifications
You must be signed in to change notification settings - Fork 1.5k
TypeSignature::Coercible for math functions #14763
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
take |
We must not encode coercion rules in every single function. |
In an extensible query engine, users should define coercion rules as part of the function definition, specifying how data types are converted. The engine itself cannot define coercion rules for every function. |
Why??
The function itself cannot define coercion rules for the engine. |
Why not? I don't see any problem with my statement |
I noticed that TypeSignatureClass::Numeric is marked as TODO, and I think math functions could benefit from using the Numeric class. Additionally, since there is no Float class, would it make sense to start by implementing Numeric first? |
Is your feature request related to a problem or challenge?
Log
for example can be handled withTypeSignature::Coercible
where the desired type is float and allow source types are integer.Describe the solution you'd like
No response
Describe alternatives you've considered
No response
Additional context
#14440
#13301
The text was updated successfully, but these errors were encountered: