core_expressions feature is broken in the datafusion-functions

[alamb]

Describe the bug

• Part of Improved CI test coverage for rust features #15155

To Reproduce

cargo check --all-targets --no-default-features -p datafusion-functions --features=core_expressions
...
error[E0425]: cannot find function `overlay` in module `crate::string`
  --> datafusion/functions/src/core/planner.rs:63:52
   |
63 |             ScalarFunction::new_udf(crate::string::overlay(), args),
   |                                                    ^^^^^^^ not found in `crate::string`

Expected behavior

We shouldn't have a feature that doesn't work

I personally suggest removing the core_expressions feature flag entirely as they are basically required for planning most SQL

The overlay function maybe needs to be moved to core 🤔 (and leave a backwards compatibility use 🤔 )

Additional context

No response

[shruti2522]

take

[Omega359]

I had no clue that feature even existed :/

[alamb]

I had no clue that feature even existed :/

Me neither -- maybe we just cargo culted it 🤷

[Omega359]

Me neither -- maybe we just cargo culted it 🤷

Wow, two new terms in one day. First was 'vibe coding' from a coworker, now 'cargo cult'. Still can teach old dogs new tricks it seems :)