Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Release script needs updating to change top-level workspace.package version #5548

Closed
andygrove opened this issue Mar 10, 2023 · 2 comments
Closed

Release script needs updating to change top-level workspace.package version #5548

andygrove opened this issue Mar 10, 2023 · 2 comments
Assignees
@andygrove
Labels
bug Something isn't working

Comments

@andygrove
Copy link
Member

Describe the bug

Because of the changes in #5519, we need to update the dev/update_datafusion_version.sh script. I have made most of the changes in #5539, but it does not update the top-level version in workspace.package and I updated that manually for this release.

To Reproduce

Expected behavior

Additional context
@andygrove andygrove added the bug Something isn't working label Mar 10, 2023
@andygrove andygrove self-assigned this Mar 10, 2023
@Jefffrey
Copy link
Contributor

Looks to have been resolved by #5767

cc @andygrove @alamb

@alamb
Copy link
Contributor

alamb commented Oct 29, 2023

I agree -- it looks like the code is present in https://github.com/apache/arrow-datafusion/blob/d24228a6b9552f2dce166836e60c1b928116933f/dev/update_datafusion_versions.py#L49-L62

Thanks @Jefffrey

@alamb alamb closed this as completed Oct 29, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@andygrove andygrove

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alamb @andygrove @Jefffrey