Skip to content

Allow multiple statements in datafusion-cli #6793

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
alamb opened this issue Jun 28, 2023 · 4 comments · Fixed by #7138
Closed

Allow multiple statements in datafusion-cli #6793

alamb opened this issue Jun 28, 2023 · 4 comments · Fixed by #7138
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@alamb
Copy link
Contributor

alamb commented Jun 28, 2023

Is your feature request related to a problem or challenge?

This has annoyed me for a while so I am filing a ticket in case someone has time to fix it

I am trying to copy/paste the reproducer for #6790 into datafusion-cli

When I try to do so I get an error about "you entered more than one statement"

❯ create table "MyTable" (
"A"    VARCHAR,
"B"    VARCHAR,
"time" timestamp
);


SELECT "A", COUNT(DISTINCT("B"))
FROM "MyTable"
WHERE time >= now() - interval '1 month'
GROUP BY "A"
LIMIT 10;
🤔 You entered more than one statement

Describe the solution you'd like

I would like datafusion-cli to execute all the statements I entered, one at at time

Describe alternatives you've considered

No response

Additional context

to run datafusion-cli:

cd datafusion-cli
cargo run

I think this is a good first issue as the code is localized and would be a nice usability improvement

@alamb alamb added enhancement New feature or request good first issue Good for newcomers labels Jun 28, 2023
@alamb
Copy link
Contributor Author

alamb commented Jun 28, 2023

cc @r4ntix as I think you have been improving datafusion-cli recently

@r4ntix
Copy link
Contributor

r4ntix commented Jun 29, 2023

@alamb
Thanks, I too think this is a good first issue.
If there are new contributors who would like to try it, I can help with this. Or on the weekend, I will come to try to improve.

@alamb
Copy link
Contributor Author

alamb commented Jun 29, 2023

Thanks, I too think this is a good first issue.

👍

If there are new contributors who would like to try it, I can help with this. Or on the weekend, I will come to try to improve.

Over the weekend often times I see new contributors look for things to do, so I would recommend giving it a few days and see if anyone responds

@NiwakaDev
Copy link
Contributor

I'd like to work on this issue.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants