Skip to content

Combine Expr::Wildcard and Expr::QualifiedWildcard, add wildcard() expr fn #8104

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
alamb opened this issue Nov 9, 2023 · 0 comments · Fixed by #8105
Closed

Combine Expr::Wildcard and Expr::QualifiedWildcard, add wildcard() expr fn #8104

alamb opened this issue Nov 9, 2023 · 0 comments · Fixed by #8105
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Nov 9, 2023

Is your feature request related to a problem or challenge?

As @waynexia points out on #8008 (comment), having Expr::Wildcard and Expr::QualifiedWildcard is confusing as they are both representing the same basic pattern, *

Specifically, I think it could make subtle bugs more likely (e.g. using Expr::Wildcard instead of using Expr::QualifiedWildcard)

Describe the solution you'd like

Combine Expr::Wildcard and Expr::QualifiedWildcard, so they can't be misused, and add wildcard() expr fn top

Describe alternatives you've considered

Do nothing

Additional context

No response

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant