Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Port tests in repartition.rs to sqllogictest #8212

Closed
Tracked by #6195
alamb opened this issue Nov 15, 2023 · 3 comments · Fixed by #8936
Closed
Tracked by #6195

Port tests in repartition.rs to sqllogictest #8212

alamb opened this issue Nov 15, 2023 · 3 comments · Fixed by #8936
Labels
good first issue Good for newcomers

Comments

@alamb
Copy link
Contributor

alamb commented Nov 15, 2023

Is your feature request related to a problem or challenge?

Part of #6195. We are trying to

  1. keep the DataFusion code base clean and easy to contribute to and modify
  2. Understand what features are covered and what are not

Part of doing so is having a single location for most test coverage so new tests can be added easily and people can follow the existing patterns easily

Describe the solution you'd like

Port the tests in https://github.com/apache/arrow-datafusion/blob/main/datafusion/core/tests/sql/repartition.rs to
repartition.slt in https://github.com/apache/arrow-datafusion/tree/main/datafusion/sqllogictest/test_files

Note you can create catalogs and schema via SQL now

Catalogs: https://arrow.apache.org/datafusion/user-guide/sql/ddl.html#create-database
Schema: https://arrow.apache.org/datafusion/user-guide/sql/ddl.html#create-schema

Notes:

  1. Instructions for running sqllogitest are here: https://github.com/apache/arrow-datafusion/tree/main/datafusion/sqllogictest

Describe alternatives you've considered

No response

Additional context

I think these are good first issues as they teach the contributor about the DataFusion codebase and tests, as well as see the end user apis in practice.

No response

@alamb
Copy link
Contributor Author

alamb commented Jan 21, 2024

The remaining tests in this file can't be ported to sqllogictest so I think this one is done

@simicd
Copy link
Contributor

simicd commented Jan 21, 2024

Hi @alamb, saw your comment only now after pushing my PR 😄 Very curious to hear your thoughts on whether it mimics the old test sufficiently closely

@alamb
Copy link
Contributor Author

alamb commented Jan 21, 2024

Oops -- sorry @simicd -- looking now

@alamb alamb reopened this Jan 21, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants