Skip to content

LogicalPlan::replace_params_with_values panics if a placeholder with id $00 is present #8614

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
kawadakk opened this issue Dec 21, 2023 · 0 comments · Fixed by #8615
Closed
Labels
bug Something isn't working

Comments

@kawadakk
Copy link
Contributor

Describe the bug

$0 (#5856) does not cause a panic anymore but $00 still does.

To Reproduce

// test $00 placeholder
let schema = Schema::new(vec![Field::new("id", DataType::Int32, false)]);

let plan = table_scan(TableReference::none(), &schema, None)
    .unwrap()
    .filter(col("id").eq(placeholder("$00")))
    .unwrap()
    .build()
    .unwrap();

plan.replace_params_with_values(&param_values.into())
    .expect_err("unexpectedly succeeded to replace an invalid placeholder");

Expected behavior

Not panicking

Additional context

No response

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
1 participant