Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Substrait : Get a ScalarFunction from name #9336

Closed
yyy1000 opened this issue Feb 24, 2024 · 2 comments · Fixed by #9337
Closed

Substrait : Get a ScalarFunction from name #9336

yyy1000 opened this issue Feb 24, 2024 · 2 comments · Fixed by #9337
Assignees
Labels
enhancement New feature or request

Comments

@yyy1000
Copy link
Contributor

yyy1000 commented Feb 24, 2024

Is your feature request related to a problem or challenge?

Part of #9285
Substrait only register BuiltinScalarFunction.
If we port BuiltInFunctons to datafusion-functions-* crates, then substrait can't call ScalarFunction because they can't find, see: #9313 (comment)

Describe the solution you'd like

I'm not quiet clear how to solve this, maybe we can register the functions in datafusion-functions-* like before, i.e. using an enum to contain all functions?

Describe alternatives you've considered

No response

Additional context

No response

@jayzhan211
Copy link
Contributor

jayzhan211 commented Feb 25, 2024

We need to support udf in Substrait, I can do this.

@alamb
Copy link
Contributor

alamb commented Feb 26, 2024

Thank you @jayzhan211 🙏

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants