Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

move Floor, Gcd, Lcm, Pi to datafusion-functions #9861

Closed
Omega359 opened this issue Mar 29, 2024 · 5 comments · Fixed by #9976
Closed

move Floor, Gcd, Lcm, Pi to datafusion-functions #9861

Omega359 opened this issue Mar 29, 2024 · 5 comments · Fixed by #9976
Assignees
Labels
enhancement New feature or request

Comments

@Omega359
Copy link
Contributor

Omega359 commented Mar 29, 2024

Is your feature request related to a problem or challenge?

As part of #9285 move the Floor, Gcd, Lcm, Pi functions to the new datafusion-functions crate in the new structure.

Describe the solution you'd like

Functions are migrated to the new crate and use the new patterns as described in #9286 & #9216

Describe alternatives you've considered

No response

Additional context

No response

@Omega359 Omega359 added the enhancement New feature or request label Mar 29, 2024
@tinfoil-knight
Copy link
Contributor

tinfoil-knight commented Mar 29, 2024

@Omega359 I realised while working on #9868 that some parts (eg: simplifying expressions: search simpl_log, simpl_power) of log & power functions are dependent on each other.

I think that these functions should be migrated together. Since you're already migrating the power function, do you want to also pick up the log function in the same PR?

@Omega359
Copy link
Contributor Author

Oh, I just created the tickets .. I wasn't attempting to do all of them @tinfoil-knight :) If you are working on something related feel free to take this ticket too

@tinfoil-knight
Copy link
Contributor

tinfoil-knight commented Mar 30, 2024

@Omega359 Thank you! I just need the Power function since it's dependent on Log.

I've opened a new issue: #9875 for it. Please update this issue to not include the Power function.

@Omega359 Omega359 changed the title move Floor, Gcd, Lcm, Pi, Power to datafusion-functions move Floor, Gcd, Lcm, Pi to datafusion-functions Mar 30, 2024
@Omega359
Copy link
Contributor Author

Omega359 commented Apr 5, 2024

take

@alamb
Copy link
Contributor

alamb commented Apr 6, 2024

❤️ -- thank you @Omega359

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants