Minor: Use slice in ConcreteTreeNode
#10666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
May 25, 2024
|
Thanks @alamb for the review! |
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea of using slices to return a node's children came up here: #10543 (comment).
While it is not possible in all
TreeNodeimplementations, the 2ConcreteTreeNodeimplementations (ExprContextandPlanContext) own their children inVecform, so there is a way to return a slice like&[Self](instead of the currentVec<&Self>).