Skip to content

Minor: improve Expr documentation #10685

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 5 commits into from
May 29, 2024
Merged

Minor: improve Expr documentation #10685

merged 5 commits into from
May 29, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented May 27, 2024

Which issue does this PR close?

Part of #7013

Rationale for this change

I was preparing to add some examples of TreeNode APIs and I noticed several places to improve Expr APIs

What changes are included in this PR?

Improve docstrings and examples

Are these changes tested?

By CI

Are there any user-facing changes?

Only doc changes, no functional changes

@alamb alamb added the documentation Improvements or additions to documentation label May 27, 2024
@alamb alamb marked this pull request as ready for review May 27, 2024 10:11
@github-actions github-actions bot added sql SQL Planner logical-expr Logical plan and expressions and removed documentation Improvements or additions to documentation labels May 27, 2024
@alamb alamb marked this pull request as draft May 27, 2024 10:12
@alamb alamb force-pushed the alamb/expr_docs branch 2 times, most recently from 2ec8f11 to a0811d8 Compare May 27, 2024 10:21
@alamb alamb force-pushed the alamb/expr_docs branch from a0811d8 to bf6567d Compare May 27, 2024 10:45
@alamb alamb marked this pull request as ready for review May 27, 2024 11:11
@alamb alamb added the documentation Improvements or additions to documentation label May 27, 2024
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @alamb

@github-actions github-actions bot removed the documentation Improvements or additions to documentation label May 29, 2024
@jonahgao jonahgao merged commit 0905426 into apache:main May 29, 2024
23 checks passed
findepi pushed a commit to findepi/datafusion that referenced this pull request Jul 16, 2024
* Minor: improve Expr documentation

* Update datafusion/expr/src/expr.rs

Co-authored-by: Oleks V <comphead@users.noreply.github.com>

* Refine words

---------

Co-authored-by: Oleks V <comphead@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
logical-expr Logical plan and expressions sql SQL Planner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants