-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[Bug] [UI] SQL node cannot be saved in certain situations #16915
Labels
bug
Something isn't working
Comments
Can you provide more error logs? |
SbloodyS
added
need more information
and removed
Waiting for reply
Waiting for reply
labels
Dec 24, 2024
API node has no error logs, only the UI reports errors. I can't obtain any useful information from the error logs.
|
There may be some error logs in |
@SbloodyS
BTW, On 2nd point, it can be saved normally when using |
Okay. I'll take a look at this in the next few days. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Search before asking
What happened
When using the SQL node, several situations have been found that prevent saving:
Using CASE WHEN statements within aggregate functions, e.g.,
SUM(CASE WHEN ... THEN ... END)
.But the format
max(case 1 when 1 then 2 end)
can be saved normallyWhen the SQL includes the aggregate function
GROUP_CONCAT()
, see issue [Bug] [UI] sql node function group_concat don't save define #14132 .Formatting, see issue The format of the sql statement prevents the workflow from being saved #15559 .
The same SQL statement in the following format can be saved.
Deployed on Kubernetes, both 3.1.x and 3.2.x have these issues.
I hope this issue can be resolved soon. Thank you!
What you expected to happen
If there is no risk of SQL injection, then regardless of the format, it should be saved normally.
How to reproduce
As above.
Anything else
No response
Version
3.1.x
Are you willing to submit PR?
Code of Conduct
The text was updated successfully, but these errors were encountered: