Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

The plugin protoc-gen-dubbo should support optional fields #1967

Closed
dixingxing0 opened this issue Jul 12, 2022 · 1 comment
Closed

The plugin protoc-gen-dubbo should support optional fields #1967

dixingxing0 opened this issue Jul 12, 2022 · 1 comment

Comments

@dixingxing0
Copy link

What would you like to be added:
protoc-gen-dubbo should support optional fields.

We run this command:
protoc -I ./ AdItemFeature.proto --dubbo_out=plugins=grpc+dubbo:.

and we meet this error:

/usr/bin/make -f /IdeaProjects/feature-service/protobuf/Makefile -C /IdeaProjects/feature-service/protobuf dubbo-gen
WARNING: Package "github.com/golang/protobuf/protoc-gen-go/generator" is deprecated.
  A future release of golang/protobuf will delete this package,
  which has long been excluded from the compatibility promise.

AdItemFeature.proto: is a proto3 file that contains optional fields, but code generator protoc-gen-dubbo hasn't been updated to support optional fields in proto3. Please ask the owner of this code generator to support proto3 optional.--dubbo_out: 
make: *** [dubbo-gen] Error

Why is this needed:
In our protobuffer definition, there are lot of optional fields, i think protoc-gen-dubbo should support them.

@dixingxing0
Copy link
Author

Seems we don't need optional in proto3.
protocolbuffers/protobuf#2497

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant