Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Bug] the waiting time of EagerThreadPoolExecutorTest#testEagerThreadPoolFast is insufficient #15204

Open
4 tasks done
zrlw opened this issue Mar 4, 2025 · 0 comments · May be fixed by #15205
Open
4 tasks done

[Bug] the waiting time of EagerThreadPoolExecutorTest#testEagerThreadPoolFast is insufficient #15204

zrlw opened this issue Mar 4, 2025 · 0 comments · May be fixed by #15205
Labels
component/need-triage Need maintainers to triage type/need-triage Need maintainers to triage

Comments

@zrlw
Copy link
Contributor

zrlw commented Mar 4, 2025

Pre-check

  • I am sure that all the content I provide is in English.

Search before asking

  • I had searched in the issues and found no similar issues.

Apache Dubbo Component

Java SDK (apache/dubbo)

Dubbo Version

dubbo 3.3

Steps to reproduce this issue

EagerThreadPoolExecutorTest.testEagerThreadPoolFast occasionally failed because of waiting timeout, see https://github.com/apache/dubbo/actions/runs/13647339272/job/38148937437

Error:  org.apache.dubbo.common.threadpool.support.eager.EagerThreadPoolExecutorTest.testEagerThreadPoolFast -- Time elapsed: 10.07 s <<< ERROR!
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in org.apache.dubbo.common.threadpool.support.eager.EagerThreadPoolExecutorTest was not fulfilled within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at org.apache.dubbo.common.threadpool.support.eager.EagerThreadPoolExecutorTest.testEagerThreadPoolFast(EagerThreadPoolExecutorTest.java:139)

the result of LoadStatusCheckerTest shows that current host(172.27.192.1) has 4 cores (cpu:4),

[INFO] Running org.apache.dubbo.common.status.support.LoadStatusCheckerTest
... ...
INFO:  [DUBBO] load status message: load:0.0,cpu:4, dubbo version: 3.3.4-SNAPSHOT, current host: 172.27.192.1

i tested EagerThreadPoolExecutorTest.testEagerThreadPoolFast on my own windows which has 4 cores, the elapsed time of new 10 threads rang from 4 seconds to 14 seconds.

What you expected to happen

decrease maximum pool size of EagerThreadPoolExecutorTest or increase waiting time.

Anything else

No response

Are you willing to submit a pull request to fix on your own?

  • Yes I am willing to submit a pull request on my own!

Code of Conduct

@zrlw zrlw added component/need-triage Need maintainers to triage type/need-triage Need maintainers to triage labels Mar 4, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
component/need-triage Need maintainers to triage type/need-triage Need maintainers to triage
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

1 participant