Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Issue] Qos port can't be disabled by externalized property #3958

Closed
mercyblitz opened this issue Apr 30, 2019 · 6 comments · Fixed by #4095
Closed

[Issue] Qos port can't be disabled by externalized property #3958

mercyblitz opened this issue Apr 30, 2019 · 6 comments · Fixed by #4095
Assignees
Labels
type/bug Bugs to being fixed
Milestone

Comments

@mercyblitz
Copy link
Contributor

Dubbo's Qos port can't be disabled by dubbo.application.qos-enable=false

@mercyblitz mercyblitz added the type/bug Bugs to being fixed label Apr 30, 2019
@mercyblitz mercyblitz added this to the 2.7.2 milestone Apr 30, 2019
@mercyblitz mercyblitz self-assigned this Apr 30, 2019
@Moriadry-zz
Copy link

Does it because we lost the QOS_ENABLE parameter in RegistryProtocol.getRegisteredProviderUrl method ? a little guess

@tswstarplanet
Copy link
Contributor

@mercyblitz I test the configuration using incubator-dubbo-spring-boot-project, and I find it can disable the Qos using dubbo.application.qos-enable=false.

@tswstarplanet
Copy link
Contributor

I use the sample in the incubator-dubbo-spring-boot-project to test

@wangwengeek
Copy link

我看官网 qos最下面又变成这样配置了试了一下管用
dubbo.application.qosEnable=true
dubbo.application.qosPort=33333
dubbo.application.qosAcceptForeignIp=false

@chickenlj
Copy link
Contributor

I also cannot reproduce the problem, dubbo.application.qos-enable=false works for boot-starter.

@chickenlj
Copy link
Contributor

But I think we should unify the the property name used in boot-starter and the core framework.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
type/bug Bugs to being fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants