Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(api): only deprecate disConnect but not disconnect #18758

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

Justineo
Copy link
Contributor

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Make disconnect no longer marked as deprecated.

Fixed issues

Details

Before: What was the problem?

image

After: How does it behave after the fixing?

image

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Jun 14, 2023

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@plainheart plainheart merged commit f27b086 into apache:master Jun 14, 2023
@echarts-bot
Copy link

echarts-bot bot commented Jun 14, 2023

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@plainheart plainheart added this to the 5.5.0 milestone Jun 14, 2023
@Justineo Justineo deleted the fix-disconnect branch June 14, 2023 07:00
@plainheart plainheart changed the title fix(api): only deprecate disConnect but not disconnect fix(api): only deprecate disConnect but not disconnect Jun 14, 2023
@plainheart plainheart modified the milestones: 5.5.0, 5.4.3 Jun 25, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants