Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(line): fix areaStyle skewing in stepped line series and incorrect connectNull behavior #20092

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

Ovilia
Copy link
Contributor

@Ovilia Ovilia commented Jun 28, 2024

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fixed issues

Resolves #20021

Details

Before: What was the problem?

areaStyle with stepped line series and connectNull is not correct.

image

After: How does it behave after the fixing?

No skewing in areaStyle.

image

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

Copy link

echarts-bot bot commented Jun 28, 2024

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

Copy link
Contributor

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20092@05ac7dd

@Ovilia Ovilia added this to the 5.5.2 milestone Jun 28, 2024
@plainheart plainheart changed the title fix(line): step areaStyle bug #20021 fix(line): fix areaStyle skewing in stepped line series and incorrect connectNull behavior Jul 18, 2024
@Ovilia Ovilia merged commit b6905aa into master Nov 6, 2024
2 checks passed
Copy link

echarts-bot bot commented Nov 6, 2024

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@Ovilia Ovilia deleted the feat-step branch November 6, 2024 06:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Line/area series step on data with nulls produces unexpected results
2 participants