Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add licenses to Markdown #10

Closed
Fokko opened this issue Jul 22, 2023 · 1 comment · Fixed by #7
Closed

Add licenses to Markdown #10

Fokko opened this issue Jul 22, 2023 · 1 comment · Fixed by #7

Comments

@Fokko
Copy link
Contributor

Fokko commented Jul 22, 2023

I noticed that we ignore markdown files:

iceberg-rust/.licenserc.yaml

Line 26 in 106be6f

- '**/*.md'

Let's also add the markdown, similar to PyIceberg: https://github.com/apache/iceberg/blob/master/python/mkdocs/docs/api.md
@Xuanwo Xuanwo mentioned this issue Jul 22, 2023
Closed
@Xuanwo
Copy link
Member

Xuanwo commented Jul 22, 2023

Wow, I didn't know we could add a license header in Markdown!

@Xuanwo Xuanwo mentioned this issue Jul 22, 2023
Merged
@Fokko Fokko closed this as completed in #7 Jul 24, 2023
ZENOTME added a commit to ZENOTME/iceberg-rust that referenced this issue Jan 8, 2025
@ZENOTME
feat: support write (apache#10)
683fb89 
* add arrow_struct_to_iceberg_struct

* refine writer interface

* support fanout partition writer

* support sort_position_delete_writer

* support equality delta writer

* support precompute partition writer

* update value convert

* fix some wrong in writer

* implement Display for NamespaceIdent

* expose _serde::DataFile

* fix FieldSummary generated from Manifest

* add delete file support for transaction

* fix record_batch_partition_spliter

* fix day transform

* fix RawLiteralEnum::Record

* fix nullable field of equality delete writer

* support to delete empty row file

* fix decimal parse for parquet statistics

---------

Co-authored-by: ZENOTME <st810918843@gmail.com>
feniljain pushed a commit to feniljain/iceberg-rust that referenced this issue Jan 20, 2025
@ZENOTME
feat: support write (apache#10)
2a97e6f 
* add arrow_struct_to_iceberg_struct

* refine writer interface

* support fanout partition writer

* support sort_position_delete_writer

* support equality delta writer

* support precompute partition writer

* update value convert

* fix some wrong in writer

* implement Display for NamespaceIdent

* expose _serde::DataFile

* fix FieldSummary generated from Manifest

* add delete file support for transaction

* fix record_batch_partition_spliter

* fix day transform

* fix RawLiteralEnum::Record

* fix nullable field of equality delete writer

* support to delete empty row file

* fix decimal parse for parquet statistics

---------

Co-authored-by: ZENOTME <st810918843@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Fokko @Xuanwo