Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Implement all functions of BoundPredicateVisitor for ManifestFilterVisitor #350

Closed
s-akhtar-baig opened this issue Apr 24, 2024 · 6 comments
Closed

Implement all functions of BoundPredicateVisitor for ManifestFilterVisitor #350

s-akhtar-baig opened this issue Apr 24, 2024 · 6 comments
Assignees
@s-akhtar-baig

Comments

@s-akhtar-baig
Copy link
Contributor

ManifestEvaluator was implemented in #322 whereas some functions are set to todo.
@s-akhtar-baig
Copy link
Contributor Author

@Fokko, can you please assign this to me? @sdd, would it be okay if I work on this?

@sdd
Copy link
Contributor

sdd commented Apr 24, 2024

Please do! That would be great 😁

@s-akhtar-baig s-akhtar-baig mentioned this issue Apr 24, 2024
Open
@liurenjie1024
Copy link
Collaborator

@s-akhtar-baig Assigned, thanks!

@Fokko Fokko mentioned this issue Apr 25, 2024
Closed
73 tasks
@marvinlanhenke
Copy link
Contributor

@s-akhtar-baig
are you still working on this? If you like I could try to help you out here?

@s-akhtar-baig
Copy link
Contributor Author

Thanks @marvinlanhenke, but I have made good progress on the task and will be creating a pull request in the next few days.

@s-akhtar-baig s-akhtar-baig mentioned this issue May 9, 2024
Merged
@s-akhtar-baig
Copy link
Contributor Author

#367 should close this issue. Most tests from pyiceberg have been implemented but some that are remaining will be covered in a follow-up PR.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@s-akhtar-baig s-akhtar-baig

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sdd @liurenjie1024 @s-akhtar-baig @marvinlanhenke