Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Snapshot Testing for Integration Tests #803

Open
feniljain opened this issue Dec 14, 2024 · 4 comments
Open

Snapshot Testing for Integration Tests #803

feniljain opened this issue Dec 14, 2024 · 4 comments

Comments

@feniljain
Copy link
Contributor

Hey everyone! 👋🏻

Creating this issue to continue discussion from these messages on possibility of using snapshot testing for integration tests:

@feniljain
Copy link
Contributor Author

@ZENOTME you mentioned:

A creative idea is to support Avro format files, allowing us to create snapshots of the entire Iceberg metadata, which can then be used for quick comparisons in end-to-end tests.

Do you mean using avro metadata files directly as snapshots? I am not sure how that addresses your concern of:

One thing we need to address maybe filter out some random field.

Am I understanding something wrong here? Can you please elaborate a bit more :)

@ZENOTME
Copy link
Contributor

ZENOTME commented Dec 16, 2024

@ZENOTME you mentioned:

A creative idea is to support Avro format files, allowing us to create snapshots of the entire Iceberg metadata, which can then be used for quick comparisons in end-to-end tests.

Do you mean using avro metadata files directly as snapshots? I am not sure how that addresses your concern of:

One thing we need to address maybe filter out some random field.

Am I understanding something wrong here? Can you please elaborate a bit more :)

Sorry, I didn't have a clear expression here. Actually, they are two things independently here.

@xxchan
Copy link
Member

xxchan commented Dec 19, 2024

I'm also a fan of snapshot testing. In this PR #822, I used expect-test to do it.

@liurenjie1024
Copy link
Contributor

Thanks @feniljain for raising this. I'm fine with snapshot testing, but currently didn't come up with a concrete example to do it.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants