Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ci: Fix CI for bindings python #678

Merged
merged 2 commits into from
Oct 23, 2024
Merged

ci: Fix CI for bindings python #678

merged 2 commits into from
Oct 23, 2024

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Oct 21, 2024

No description provided.

Copy link
Contributor

@sungwy sungwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Xuanwo does this mean we would have to find a different approach to address the issue attempted to be resolved in #666 ?

Copy link
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a revert of #666. CI looks good now https://github.com/apache/iceberg-rust/commits/main/

Will this break CI again?

@Xuanwo
Copy link
Member Author

Xuanwo commented Oct 22, 2024

Hi, @kevinjqliu @sungwy, thank you for the review!

Github fix this from the runner side: actions/runner-images#10794

I plan to add setup-python in every places we are going to use pip in the following PRs.

@Xuanwo Xuanwo merged commit 6f392e3 into main Oct 23, 2024
16 checks passed
@kevinjqliu
Copy link
Contributor

FYI, CI failing on main
https://github.com/apache/iceberg-rust/commits/main/

Is it related to this PR?

error message,

error: use of deprecated method `opendal::Operator::is_exist`: rename to `exists` for consistence with `std::fs::exists`
   --> crates/iceberg/src/io/file_io.rs:100:15
    |
100 |         Ok(op.is_exist(relative_path).await?)
    |               ^^^^^^^^
    |
    = note: `-D deprecated` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(deprecated)]`

error: use of deprecated method `opendal::Operator::is_exist`: rename to `exists` for consistence with `std::fs::exists`
   --> crates/iceberg/src/io/file_io.rs:246:14
    |
246 |             .is_exist(&self.path[self.relative_path_pos..])
    |              ^^^^^^^^

error: use of deprecated method `opendal::Operator::is_exist`: rename to `exists` for consistence with `std::fs::exists`
   --> crates/iceberg/src/io/file_io.rs:328:14
    |
328 |             .is_exist(&self.path[self.relative_path_pos..])
    |              ^^^^^^^^

@Xuanwo
Copy link
Member Author

Xuanwo commented Oct 23, 2024

FYI, CI failing on main

https://github.com/apache/iceberg-rust/commits/main/

Is it related to this PR?

error message,


error: use of deprecated method `opendal::Operator::is_exist`: rename to `exists` for consistence with `std::fs::exists`

   --> crates/iceberg/src/io/file_io.rs:100:15

    |

100 |         Ok(op.is_exist(relative_path).await?)

    |               ^^^^^^^^

    |

    = note: `-D deprecated` implied by `-D warnings`

    = help: to override `-D warnings` add `#[allow(deprecated)]`



error: use of deprecated method `opendal::Operator::is_exist`: rename to `exists` for consistence with `std::fs::exists`

   --> crates/iceberg/src/io/file_io.rs:246:14

    |

246 |             .is_exist(&self.path[self.relative_path_pos..])

    |              ^^^^^^^^



error: use of deprecated method `opendal::Operator::is_exist`: rename to `exists` for consistence with `std::fs::exists`

   --> crates/iceberg/src/io/file_io.rs:328:14

    |

328 |             .is_exist(&self.path[self.relative_path_pos..])

    |              ^^^^^^^^

Not related. opendal released a new version. I will fix it.

shaeqahmed pushed a commit to matanolabs/iceberg-rust that referenced this pull request Dec 9, 2024
* ci: Fix CI for bindings python

* Update bindings_python_ci.yml
@Xuanwo Xuanwo deleted the Xuanwo-patch-1 branch December 13, 2024 10:49
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants