-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Adding UDP logger plugin #1070
Adding UDP logger plugin #1070
Conversation
There are performance issues with the per-request log message mode. It is better to put log messages in the queue first, and then send them in batches. |
Done is better then perfect. I think we can use another PR to fix performance issues. |
|
@membphis The following is the final log sent to the server. {
"upstream": "127.0.0.1:80",
"start_time": 1579231324391,
"client_ip": "127.0.0.1",
"service_id": "10",
"route_id": "5",
"request": {
"querystring": {
"param1": "value"
},
"size": 118,
"uri": "/?param1=value",
"url": "http://127.0.0.1:9080/?param1=value",
"headers": {
"host": "127.0.0.1:9080",
"apikey": "superSecretAPIKey",
"accept": "*/*",
"user-agent": "curl/7.58.0"
},
"method": "GET"
},
"response": {
"headers": {
"accept-ranges": "bytes",
"content-type": "text/html",
"date": "Fri, 17 Jan 2020 03:22:04 GMT",
"server": "APISIX web server",
"connection": "close",
"last-modified": "Thu, 29 Aug 2019 23:49:13 GMT",
"etag": "\"5d686479-289\"",
"content-length": "649"
},
"status": 200,
"size": 892
},
"latency": 0.99992752075195
} should I round the number for latency? |
Recommended to milliseconds. |
@membphis the review comments have been resolved, thanks for the pointers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good to me
The UDP logger sends the logs to a UDP server.
Fix for #1069